Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header. #4116

Merged
merged 1 commit into from Jun 9, 2014
Merged

Add missing header. #4116

merged 1 commit into from Jun 9, 2014

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Jun 5, 2014

No description provided.

@ktf ktf closed this Jun 5, 2014
@ktf ktf reopened this Jun 5, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2014

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Add missing header.

It involves the following packages:

PhysicsTools/ParallelAnalysis

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

@monttj
Copy link
Contributor

monttj commented Jun 9, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor Author

ktf commented Jun 9, 2014

Bypassing ORP approval. This is needed because clang is more picky about templates and forward declarations.

ktf added a commit that referenced this pull request Jun 9, 2014
@ktf ktf merged commit 0289a7b into cms-sw:CMSSW_7_1_X Jun 9, 2014
@ktf ktf deleted the add-missing-header branch June 9, 2014 17:59
ktf added a commit to ktf/cmssw that referenced this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants