Added option to trigger on loose HMT showers in EMTF #41185

eyigitba · 2023-03-25T15:09:18Z

PR description:

Starting from 2023 we will trigger on loose showers in EMTF. This information will be used in uGMT to build the TwoLooseDiffSectorInTime trigger.

I also cleaned the configurable parameters nLooseShowers_, nNominalShowers_, and nTightShowers_. The number of showers is already indicated in the boolean name and these configurables don't really add any configuration options. i.e the condition for hasOneNominalInTime should always be one or more showers.

The data format changes were done in #40890 and uGMT logic update is done in #41042

PR validation:

Validated by producing ntuples which had expected amount of loose showers.

Also ran runTheMatrix.py -l limited -i all --ibeos with no failures.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be backported to 13_0_X, but it depends also on the backport of #40890

…rameters.

cmsbuild · 2023-03-25T15:17:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41185/34871

This PR adds an extra 16KB to repository

cmsbuild · 2023-03-25T15:17:45Z

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

L1Trigger/L1TMuonEndCap (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @JanFSchulte, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2023-03-25T18:10:12Z

please test

cmsbuild · 2023-03-25T20:41:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f11ca3/31591/summary.html
COMMIT: 22a87cd
CMSSW: CMSSW_13_1_X_2023-03-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41185/31591/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554286
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554252
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

aloeliger · 2023-03-27T09:03:27Z

+l1

cmsbuild · 2023-03-27T09:03:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta

Very minor comments
@eyigitba @aloeliger please decide whether you think it is worth implementing them, or if you are really hurried up and want to merge right now. (In any case, applying the text fixes, rerunning the tests, and re-signing for L1 can take less than half a day: perhaps it cold be already merged in time for the 2300 IB, if you act quickly).

L1Trigger/L1TMuonEndCap/interface/SectorProcessorShower.h

L1Trigger/L1TMuonEndCap/plugins/L1TMuonEndCapShowerProducer.cc

aloeliger · 2023-03-27T14:43:38Z

L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc

  enableTwoLooseShowers_ = pset.getParameter<bool>("enableTwoLooseShowers");
  enableOneNominalShower_ = pset.getParameter<bool>("enableOneNominalShowers");
  enableOneTightShower_ = pset.getParameter<bool>("enableOneTightShowers");


I think these are the wrong name for these things now? Should be Shower?

yes, exactly. Apparently I missed these. I changed them now.

aloeliger · 2023-03-27T14:44:17Z

Ahh, already got it by the time I said that.

cmsbuild · 2023-03-27T14:50:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41185/34893

This PR adds an extra 16KB to repository

cmsbuild · 2023-03-27T14:51:06Z

Pull request #41185 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

aloeliger · 2023-03-27T14:51:11Z

please test

cmsbuild · 2023-03-27T17:15:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f11ca3/31619/summary.html
COMMIT: 6a1fe23
CMSSW: CMSSW_13_1_X_2023-03-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41185/31619/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554286
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554255
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

aloeliger · 2023-03-27T20:19:39Z

+l1

cmsbuild · 2023-03-27T20:20:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-03-27T21:31:20Z

+1

Added option to trigger on loose HMT showers. Cleaned configurable pa…

22a87cd

…rameters.

cmsbuild added this to the CMSSW_13_1_X milestone Mar 25, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 25, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 25, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 25, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 25, 2023

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Mar 27, 2023

perrotta reviewed Mar 27, 2023

View reviewed changes

L1Trigger/L1TMuonEndCap/interface/SectorProcessorShower.h Outdated Show resolved Hide resolved

L1Trigger/L1TMuonEndCap/plugins/L1TMuonEndCapShowerProducer.cc Outdated Show resolved Hide resolved

Minor text fixes.

44d3826

cmsbuild added l1-pending and removed l1-approved fully-signed tests-approved code-checks-approved labels Mar 27, 2023

Fix config parameter name in SectorProcessorShower.cc

6a1fe23

aloeliger reviewed Mar 27, 2023

View reviewed changes

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Mar 27, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 27, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2023

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Mar 27, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 27, 2023

cmsbuild merged commit 7d5413a into cms-sw:master Mar 27, 2023

cmsbuild mentioned this pull request Mar 28, 2023

Herwig lhe matching fix #40939

Merged

eyigitba mentioned this pull request Mar 28, 2023

Added option to trigger on loose HMT showers in EMTF #41209

Merged

epalencia mentioned this pull request Mar 30, 2023

Added option to trigger on loose HMT showers in EMTF (backport of 41185) cms-l1t-offline/cmssw#1085

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added option to trigger on loose HMT showers in EMTF #41185

Added option to trigger on loose HMT showers in EMTF #41185

eyigitba commented Mar 25, 2023

cmsbuild commented Mar 25, 2023

cmsbuild commented Mar 25, 2023

aloeliger commented Mar 25, 2023

cmsbuild commented Mar 25, 2023

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

perrotta left a comment

aloeliger Mar 27, 2023

eyigitba Mar 27, 2023

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

perrotta commented Mar 27, 2023

Added option to trigger on loose HMT showers in EMTF #41185

Added option to trigger on loose HMT showers in EMTF #41185

Conversation

eyigitba commented Mar 25, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 25, 2023

cmsbuild commented Mar 25, 2023

aloeliger commented Mar 25, 2023

cmsbuild commented Mar 25, 2023

Comparison Summary

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

perrotta left a comment

Choose a reason for hiding this comment

aloeliger Mar 27, 2023

Choose a reason for hiding this comment

eyigitba Mar 27, 2023

Choose a reason for hiding this comment

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

Comparison Summary

aloeliger commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

perrotta commented Mar 27, 2023