Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Herwig lhe matching fix" #41237

Merged
merged 1 commit into from Mar 31, 2023
Merged

Conversation

perrotta
Copy link
Contributor

Reverts #40939
See github issue #41230 for details

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/Herwig7Interface (generators)
  • GeneratorInterface/LHEInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @alberto-sanchez, @mkirsano, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

test parameters:

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28df9/31697/summary.html
COMMIT: 176d3eb
CMSSW: CMSSW_13_1_X_2023-03-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41237/31697/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28df9/31697/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c28df9/31697/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 35 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3552561
  • DQMHistoTests: Total failures: 500
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3552031
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -808.875 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -383.814 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 12434.0,... ): -49.806 KiB HLT/Filters
  • DQMHistoSizes: changed ( 12434.0,... ): 23.594 KiB HLT/EGM
  • DQMHistoSizes: changed ( 12434.0 ): 14.171 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 12434.0 ): -4.324 KiB HLT/SMP
  • DQMHistoSizes: changed ( 12434.0 ): 1.283 KiB HLT/TAU
  • DQMHistoSizes: changed ( 139.001 ): 0.047 KiB HLT/TAU
  • Checked 217 log files, 168 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor Author

@cmsbuild cmsbuild merged commit 5cb57fc into master Mar 31, 2023
12 checks passed
@perrotta perrotta deleted the revert-40939-herwig_lhe_matching_fix branch May 1, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants