remove unused variable

[pvmulder]

unused variable removed
does not affect standard reconstruction

[cmsbuild]

A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_7_1_X.

remove unused variable

It involves the following packages:

RecoBTag/SecondaryVertex

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ferencek this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4140/1667/summary.html

[StoyanStoynev]

@pvmulder , in what sense is the variable not used, isn't it upto the analysis code? How was it decided the variable would not be needed again and why is this considered a bugfix (to put in 71X at this stage)?

[pvmulder]

No, it is not up to the analysis code. This is a new b-tagger that is under development and it is up to the developer which variables are used. Actually the leptonP0Par was not filled properly (it is empty) and was already removed for the muons, but I forgot to remove it for the electrons. In that sense it is a bug fix.

[StoyanStoynev]

OK, do I get it right that other variables (like leptonRatioRel ) are YET to be used in the code - for now they are just inserted in a TaggingVariableList?

[pvmulder]

That is correct in the sense that the CombinedSVSoftLeptonComputer.cc is not included in the standard reconstruction sequence. So this fix only matters to developers and not to users.

[StoyanStoynev]

+1
Apparently jenkins comparisons will run forever...
Tested 2ca50cf with CMSSW_7_1_X_2014-06-13-0200.
I ran short matrix tests and checked results from FWlite and DQM scripts (plus the part from jenkins tests available). No diffs, see also #4139.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4140/1667/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?