cleanup spurious change introduced in PAT photon/muon producer auto fwd-port in 2015

[slava77]

partly as a follow up to #41396 I was somewhat non-comprehensively looking at other changes from automatic forward ports

2315273#diff-2fdb475ba7d21b78d12e835c8df71fd7a251210fc88ebd4bc8ec6fd2b1dbb2c4L200-L201

was an auto-forward port of #10671 (75X) which in turn was a backport of #11140 (76X; initial version #10620) but there were enough nested merges and differences that the porting got apparently confused

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41403/35269

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

• PhysicsTools/PatAlgos (xpog, reconstruction)

@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @AnnikaStein, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbe84/32138/summary.html
COMMIT: 8cbe321
CMSSW: CMSSW_13_1_X_2023-04-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41403/32138/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jfernan2 DQM perLS in one shot (part 2) #41375
• @iarspider Remove PhysicsTools/MXNet (cms-sw/cmssw#30432) #41377
• @hahnjo Remove checks for Geant4 version #41392
• @mmusich fix some bugs in the TrackerAlignment DiMuonValidation code #41393
• @menglu21 renew matched lepton ids for every jet #41325
• @mmusich Improve vertexing monitoring for Tracker Alignment AlCaReco samples #41378
• @bsunanda Phase2-hgx338A First step to introduce calibration cells for HGCAL silicon sensors #41390

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbe84/32138/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbe84/32138/git-merge-result

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

[slava77]

I found compilation warning while trying to compile with clang

in the log I see SimG4Core/PhysicsLists/src/CMSHepEmTrackingManager.cc

Apparently something was merged that fails clang tests now; or there was an external dependency that's not recognized by the tests.

the tests will need to be rerun after the next IB shows up

[smuzaffar]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9fbe84/32144/summary.html
COMMIT: 8cbe321
CMSSW: CMSSW_13_1_X_2023-04-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41403/32144/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 14 lines to the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460685
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460657
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[vlimant]

+1

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1