jetAlgo name to AK5PFchs; Cloning corrections, applied on ak4 jets

[nadjieh]

This includes the following:

• move to EI
• temporary solution for the "algorithm" name for Ak5CHSJets in corrections
• ak5 corrections to be applied to ak4 jets (temporary)
• tests 1,2,11,12,4,9 are checked and they were OK

[cmsbuild]

A new Pull Request was created by @nadjieh (Abideh Jafari) for CMSSW_7_2_X.

jetAlgo name to AK5PFchs; Cloning corrections, applied on ak4 jets

It involves the following packages:

DQM/Physics

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4148/68/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4148/68/summary.html

[deguio]

is this needed?

[deguio]

hello @nadjieh
sorry for being late in reviewing this PR. I have made comments in the code trying to keep the DQM/Physics/python/DQMPhysics_cff.py as clean as possible.

in addition I would like to ask you to rebase your branch on top of CMSSW_7_1_0_pre9 or at least make sure that the code correctly merges with #4142 #4143

thank you in advance,
F.

[nadjieh]

Hi @deguio,

The things added to DQMPhysics are necessary. These are all the mess we
have to have due to the jet algorithms in the correctors.
I understand that it is not in our interest to make any mess in DQMPhysics
but for the time being we seem to have no other option.
Once the GT content is corrected, we can get rid of these lines.

Thanks,
Nadjieh

On 12 June 2014 17:35, deguio notifications@github.com wrote:

hello @nadjieh https://github.com/nadjieh
sorry for being late in reviewing this PR. I have made comments in the
code trying to keep the DQM/Physics/python/DQMPhysics_cff.py as clean as
possible.

in addition I would like to ask you to rebase your branch on top of
CMSSW_7_1_0_pre9 or at least make sure that the code correctly merges with
#4142 #4142 #4143
#4143

thank you in advance,
F.

—
Reply to this email directly or view it on GitHub
#4148 (comment).

[deguio]

-1
superseded by #4229