Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] HGCAL: Fix HGCHEB isSiFE configuration #41563

Merged

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR fixes a bug introduced in #39720 .
The parameter isSiFE was set to False by mistake which caused the energy scale in HGCAL scintillator (HEB) rechits to be shifted. Setting the isSiFE parameter back to True fixes the issue.

PR validation:

The PR was tested with: runTheMatrix.py -w upgrade -l 25300.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of: #41547

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

A new Pull Request was created by @stahlleiton (Andre Stahl) for CMSSW_13_1_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoLocalCalo/HGCalRecProducers (upgrade, reconstruction)

@Martin-Grunewald, @missirol, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @vandreev11, @edjtscott, @sethzenz, @bsunanda, @silviodonato, @felicepantaleo, @SohamBhattacharya, @missirol, @lgray, @Martin-Grunewald, @apsallid, @cseez, @pfs, @lecriste, @hatakeyamak, @ebrondol, @sameasy, @rovere, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented May 5, 2023

please test

@missirol
Copy link
Contributor

missirol commented May 5, 2023

backport of #41547

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97a3ed/32427/summary.html
COMMIT: 4844a5f
CMSSW: CMSSW_13_1_X_2023-05-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41563/32427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 761 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 644
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460211
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented May 8, 2023

+hlt

Bugfix for HGCal by HGCal DPG. I assume @beaucero and @SohamBhattacharya are okay with having it in the HLT Phase-2 menu.

@mandrenguyen
Copy link
Contributor

type hgcal

@mandrenguyen
Copy link
Contributor

+reconstruction

@missirol
Copy link
Contributor

@cms-sw/upgrade-l2 , any issue with signing this backport ?

@SohamBhattacharya
Copy link
Contributor

+upgrade

Had overlooked this, sorry.

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2d4ddab into cms-sw:CMSSW_13_1_X May 10, 2023
21 checks passed
@stahlleiton stahlleiton deleted the from-CMSSW_13_1_0_pre4_isSiFE_Fix branch December 19, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants