New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jet core step from710pre8 fixed #4162
Conversation
Conflicts: RecoTracker/CkfPattern/src/TrajectorySegmentBuilder.cc RecoTracker/FinalTrackSelectors/python/MergeTrackCollections_cff.py RecoTracker/IterativeTracking/python/iterativeTk_cff.py
Conflicts: RecoTracker/FinalTrackSelectors/python/MergeTrackCollections_cff.py RecoTracker/IterativeTracking/python/iterativeTk_cff.py
This reverts commit a6a6ffd.
…rger to prefer tracks with more pixel hits
… to tell SeedFromConsecutiveHitsCreator to recompute the initial seed kinematic taking into account the direction of the possible eta-phi region used to limit the seeding area
This reverts commit 55f1b90.
This error looks not related with this PR
|
Indeed, it looks like some frontier server issue. |
+1 |
Here is a bit of a summary, for the record. Overall, changes are as expected and I don't see anything bad on the physics side.
|
@arizzi |
+1 for #4162 4c7a4e3 Compared to #3859 fdb4eb4 (tested in pre8) and this PR, the jet core became slower, almost all of the slow down is in jetCoreRegionalStepTrackCandidates (it now takes x3 or so more time than it did in pre8). |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
It's the bugfix, it was not taking the proper maxcand
|
do you mean this one cerati@f7e6c67 |
@slava77 let me be more clear, in the old version the increased maxCand that is needed was not taken because a bug in the configuration due to migration of tracking config not propagated to the jetcore step. With the bug fixed (those commits above) now maxCand is larger and it takes more time (i.e. the original PR was buggy, this one has been fixed). |
New PR replacing #4113.
without the iteration-based priority logic in the track merging but with double weight for pixel hits.
@arizzi