Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vector reserve in SeedGeneratorFromRegionHits #4180

Merged

Conversation

mark-grimes
Copy link

Removes a vector reserve that at 140 pileup massively overestimates the size required. Removing it does not noticeably increase runtime. Memory use and timing before and after were presented in the 05/Jun/2014 reconstruction meeting (https://indico.cern.ch/event/321540/session/4/contribution/13/material/slides/0.pdf).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Remove vector reserve in SeedGeneratorFromRegionHits

It involves the following packages:

RecoTracker/TkSeedGenerator

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Jun 10, 2014
Remove vector reserve in SeedGeneratorFromRegionHits
@cmsbuild cmsbuild merged commit bd8b936 into cms-sw:CMSSW_6_2_X_SLHC Jun 10, 2014
@mark-grimes mark-grimes deleted the removeSeedGeneratorReserve branch June 16, 2014 07:32
makortel pushed a commit to makortel/cmssw that referenced this pull request Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants