Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #4195 also applied to ME0GeometryBuilderFromCondDB #4199

Merged
merged 2 commits into from Jun 11, 2014

Conversation

mark-grimes
Copy link

@dildick created a fix for an intermittent crash with #4195 which fixes ME0GeometryBuilderFromCondDDD. This applies the same fix to ME0GeometryBuilderFromCondDB. I have no idea if this code is ever used but figured it was better to fix it in case it is, since the crash is intermittent and hard to trace. This also includes #4195.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Pull request #4195 also applied to ME0GeometryBuilderFromCondDB

It involves the following packages:

Geometry/GEMGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@dildick
Copy link
Contributor

dildick commented Jun 10, 2014

Hi, I guess at some point in the future ME0GeometryBuilderFromCondDB would be used if ME0 were an approved project with a geometry in DB.

I tested this in workflow 13000; runs fine. If -999 is an error-prone value, you can change it to +999. It won't matter for the DIGI-RECO performance.

@ianna
Copy link
Contributor

ianna commented Jun 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

@mark-grimes
Copy link
Author

merge

All tests pass except for failures with know errors. Tested with 4 muons and single pion.

cmsbuild added a commit that referenced this pull request Jun 11, 2014
Pull request #4195 also applied to ME0GeometryBuilderFromCondDB
@cmsbuild cmsbuild merged commit c4975d5 into cms-sw:CMSSW_6_2_X_SLHC Jun 11, 2014
@mark-grimes mark-grimes deleted the bugfixME0StripsPads branch June 16, 2014 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants