Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread-safe #4262

Merged
merged 1 commit into from Jun 25, 2014
Merged

thread-safe #4262

merged 1 commit into from Jun 25, 2014

Conversation

threus
Copy link
Contributor

@threus threus commented Jun 16, 2014

Strip thread-safe updates according to request from DQM:
https://hypernews.cern.ch/HyperNews/CMS/get/dqmDevel/2214.html

and removed static variables as suggested by @deguio from #4069

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @threus for CMSSW_7_1_X.

thread-safe

It involves the following packages:

DQM/SiStripMonitorHardware

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jun 16, 2014

+1
it seems to me that these changes make the FEDErrors class thread friendly.
thanks @threus.

[needed for the GR in July]

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

@deguio - is this already in 72x?

@deguio
Copy link
Contributor

deguio commented Jun 17, 2014

this is not. when is the automatic PR generated in 72? as soon as this is merged?
I agree that it would be nice to have this tested in some IB before the integration in 71X. several PR are in the same conditions.

@davidlange6
Copy link
Contributor

@deguio - my idea in general was to use 720pre1 for exactly that

@deguio
Copy link
Contributor

deguio commented Jun 17, 2014

@threus could you submit this PR to 72X also?
thank you in advance,
F.

@threus threus mentioned this pull request Jun 17, 2014
@ktf ktf modified the milestones: Next CMSSW_7_1_X, CMSSW_7_1_0 Jun 23, 2014
davidlange6 added a commit that referenced this pull request Jun 25, 2014
@davidlange6 davidlange6 merged commit dbb1023 into cms-sw:CMSSW_7_1_X Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants