Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new FED IDs for future uTCA FEDs #4268

Merged
merged 1 commit into from Jun 17, 2014

Conversation

mommsen
Copy link
Contributor

@mommsen mommsen commented Jun 16, 2014

Add new FED ID ranges for the future uTCA FEDs to be added for/during run 2. Increment the maximum number of FED IDs to accommodate those new ranges. I checked as far as I could that this does not break any existing code in CMSSW 7_X_Y.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mommsen (Remi Mommsen) for CMSSW_7_1_X.

Add new FED IDs for future uTCA FEDs

It involves the following packages:

DataFormats/FEDRawData

@mommsen, @cmsbuild, @Degano, @emeschi, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mommsen
Copy link
Contributor Author

mommsen commented Jun 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 17, 2014
Add new FED IDs for future uTCA FEDs
@davidlange6 davidlange6 merged commit e47c723 into cms-sw:CMSSW_7_1_X Jun 17, 2014
@mommsen mommsen deleted the newFedIds branch June 18, 2014 09:26
@ktf ktf mentioned this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants