Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgc detidfix #4311

Merged
merged 3 commits into from Jun 23, 2014
Merged

Hgc detidfix #4311

merged 3 commits into from Jun 23, 2014

Conversation

pfs
Copy link
Contributor

@pfs pfs commented Jun 19, 2014

I have added a protection for the subsector received at construction time in the HGC sim and reco DetIds.
In the HGC digitizer I have also included the simulation of noise for all available DetIds.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pfs (Pedro Silva) for CMSSW_6_2_X_SLHC.

Hgc detidfix

It involves the following packages:

DataFormats/ForwardDetId
SimCalorimetry/HGCSimProducers

The following packages do not have a category, yet:

DataFormats/ForwardDetId
SimCalorimetry/HGCSimProducers

@cmsbuild, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Jun 20, 2014

@mark-grimes @fratnikov After this PR is merged, I need to rebase a branch and then submit a dependent PR for PF.

@cmsbuild
Copy link
Contributor

Pull request #4311 was updated. @civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @ktf can you please check and sign again.

@mark-grimes
Copy link

merge

Tested with 4 muons and pions, only the known issues in harvesting.

cmsbuild added a commit that referenced this pull request Jun 23, 2014
@cmsbuild cmsbuild merged commit 20e075c into cms-sw:CMSSW_6_2_X_SLHC Jun 23, 2014
@pfs pfs deleted the hgc_detidfix branch November 18, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants