Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for icc: change unsigned int to size_t when looping over vector elements #4312

Merged
merged 1 commit into from Jun 26, 2014
Merged

fix for icc: change unsigned int to size_t when looping over vector elements #4312

merged 1 commit into from Jun 26, 2014

Conversation

smuzaffar
Copy link
Contributor

change unsigned int to size_t to avoid strange icc optimization which causes segfault. This is the right thing to do any way

… causes segfault. This is the right thing to do any way
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_5_3_X.

fix fro icc: change unsigned int to size_t when looping over vector elements

It involves the following packages:

PhysicsTools/MVAComputer

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor Author

+tested

@davidlt
Copy link
Contributor

davidlt commented Jun 19, 2014

Could you also attempt to generate a small testcase, pre-process it and send to Intel people?

@ktf
Copy link
Contributor

ktf commented Jun 19, 2014

Already done.

@smuzaffar smuzaffar changed the title fix fro icc: change unsigned int to size_t when looping over vector elements fix for icc: change unsigned int to size_t when looping over vector elements Jun 19, 2014
@smuzaffar
Copy link
Contributor Author

icc has mange to reproduce it and problem is with optimization by inlining.
This is anyway the right fix, so bypassing it

smuzaffar added a commit that referenced this pull request Jun 26, 2014
fix for icc: change unsigned int to size_t when looping over vector elements
@smuzaffar smuzaffar merged commit 522bd90 into cms-sw:CMSSW_5_3_X Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants