New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forward port 71x #4316
Fix forward port 71x #4316
Conversation
…opy in MVAComputer.cc
Fix fragment
…es of tau energy scale
…e and a way to find duplicates during construction, Fix a subtle bug do to re-used objects
…es_for700pre13 7 0 x input files for700pre13
Fix post ls1 customs 70 x
@ktf - are tests running on this PR? (4316) |
@slava77 I think miniaod part4 can mostly be forward ported, the only thing I'd check is that commit |
…is_for_Premixing 7_0_X Change DataMixer to merge CSC Strip Digis instead of adding duplic...
70 x hcal pre mix bugfix
Add missing customize.
Pull request #4316 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @monttj, @cmsbuild, @franzoni, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @Degano, @ktf, @davidlange6 can you please check and sign again. |
should be OK for RECO, waiting for jenkins though |
Pull request #4316 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @monttj, @cmsbuild, @franzoni, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @Degano, @ktf, @davidlange6 can you please check and sign again. |
Final update. #4325 ignored as suggested by @davidlange6 , #4328 added. |
@ktf - what's the state of tests for this pr? |
For some reason it did not merge. Running it again. |
Ok, I'll merge it so that we can try it out in the IB at this point. |
@@ -102,8 +105,13 @@ | |||
<version ClassVersion="10" checksum="2692173055"/> | |||
</class> | |||
<class name="std::vector<pat::tau::TauCaloSpecific>" /> | |||
<class name="pat::Photon" ClassVersion="12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here. I get a
>> Checking EDM Class Version for src/DataFormats/PatCandidates/src/classes_def_objects.xml in libDataFormatsPatCandidatesCapabilities.so
LD_LIBRARY_PATH=/build/eulisse/CMSSW_7_1_0-build/tmp/BUILDROOT/d8755e73764cac50b87d5c1648a3c5a6/opt/cmssw/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_0/tmp/slc6_amd64_gcc481/src/DataFormats/PatCandi
Automatic building of dictionaries now off
error: class 'pat::Photon' has a different checksum for ClassVersion 13. Increment ClassVersion to 14 and assign it to checksum 2518470540
gmake: *** [tmp/slc6_amd64_gcc481/src/DataFormats/PatCandidates/src/DataFormatsPatCandidates/libDataFormatsPatCandidatesCapabilities.so] Error 1
when building the release (but not in the IB..:-/). Ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed ClassVersion 12 has 2518470540 as a checksum. Do I understand right that pat::Photon
was changes in CMSSW_7_0_X but not in CMSSW_7_1_X? If yes, I guess the solution is simply to revert the change.
For the record, this made CMSSW_7_1_0. |
By hand fix of merge of CMSSW_7_0_X into CMSSW_7_1_X.
The following PR were picked up (recent first):
The following were ignored and will not be forward ported: