Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward port 71x #4316

Merged
merged 63 commits into from Jun 20, 2014
Merged

Fix forward port 71x #4316

merged 63 commits into from Jun 20, 2014

Conversation

pvmulder and others added 30 commits May 9, 2014 15:08
…e and a way to find duplicates during construction, Fix a subtle bug do to re-used objects
…es_for700pre13

7 0 x input files for700pre13
@davidlange6
Copy link
Contributor

@ktf - are tests running on this PR? (4316)

@arizzi
Copy link
Contributor

arizzi commented Jun 20, 2014

@slava77 I think miniaod part4 can mostly be forward ported, the only thing I'd check is that commit
ktf@c251751 doesn't mess up with substructures as they are in 71X/72X (but in principle it was obtained from single file checkout of 71X so it should be safe). @ktf can you check that such commit is actually doing nothing on top of 71X/72X ?

@ktf
Copy link
Contributor Author

ktf commented Jun 20, 2014

I've added a few more pull requests (#4318 and #4326) which were merged in the meanwhile. #4325 is tricky though, since it conflicts. Should it really be forward ported?

@cmsbuild
Copy link
Contributor

Pull request #4316 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @monttj, @cmsbuild, @franzoni, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @Degano, @ktf, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jun 20, 2014

should be OK for RECO, waiting for jenkins though

@cmsbuild
Copy link
Contributor

Pull request #4316 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @monttj, @cmsbuild, @franzoni, @Dr15Jones, @StoyanStoynev, @slava77, @vadler, @Degano, @ktf, @davidlange6 can you please check and sign again.

@ktf
Copy link
Contributor Author

ktf commented Jun 20, 2014

Final update. #4325 ignored as suggested by @davidlange6 , #4328 added.

@davidlange6
Copy link
Contributor

@ktf - what's the state of tests for this pr?

@ktf
Copy link
Contributor Author

ktf commented Jun 20, 2014

For some reason it did not merge. Running it again.

@ktf
Copy link
Contributor Author

ktf commented Jun 20, 2014

Ok, I'll merge it so that we can try it out in the IB at this point.

ktf added a commit that referenced this pull request Jun 20, 2014
@ktf ktf merged commit 40cdad5 into cms-sw:CMSSW_7_1_X Jun 20, 2014
@@ -102,8 +105,13 @@
<version ClassVersion="10" checksum="2692173055"/>
</class>
<class name="std::vector<pat::tau::TauCaloSpecific>" />
<class name="pat::Photon" ClassVersion="12">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here. I get a

>> Checking EDM Class Version for src/DataFormats/PatCandidates/src/classes_def_objects.xml in libDataFormatsPatCandidatesCapabilities.so
LD_LIBRARY_PATH=/build/eulisse/CMSSW_7_1_0-build/tmp/BUILDROOT/d8755e73764cac50b87d5c1648a3c5a6/opt/cmssw/slc6_amd64_gcc481/cms/cmssw/CMSSW_7_1_0/tmp/slc6_amd64_gcc481/src/DataFormats/PatCandi
Automatic building of dictionaries now off
error: class 'pat::Photon' has a different checksum for ClassVersion 13. Increment ClassVersion to 14 and assign it to checksum 2518470540
gmake: *** [tmp/slc6_amd64_gcc481/src/DataFormats/PatCandidates/src/DataFormatsPatCandidates/libDataFormatsPatCandidatesCapabilities.so] Error 1

when building the release (but not in the IB..:-/). Ideas?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed ClassVersion 12 has 2518470540 as a checksum. Do I understand right that pat::Photon was changes in CMSSW_7_0_X but not in CMSSW_7_1_X? If yes, I guess the solution is simply to revert the change.

@ktf
Copy link
Contributor Author

ktf commented Jun 23, 2014

For the record, this made CMSSW_7_1_0.

@ktf ktf deleted the fix-forward-port-71x branch June 23, 2014 07:06
@ktf ktf mentioned this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet