Eta Range Calo Jet Selector

[silviodonato]

I proposed to add a simple EtaRangeCaloJetSelector. It is needed for the HLT b-tag sequence

[cmsbuild]

A new Pull Request was created by @silviodonato for CMSSW_7_2_X.

Eta Range Calo Jet Selector

It involves the following packages:

CommonTools/RecoAlgos

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: 1a45750
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4332/165/summary.html

[perrotta]

Hi @slava77: could you please check and, if you agree with it, sign this simple pull request.
If it is done in time, we could even try to backport it into 71X before Wednesday, and have it available in the patch release meant for the GlobalRun [1]. Since it is just the addition of a new module and it does not touch any of the current workflows in 71X, I expect it can be done if you agree with it.
Thank you,
Andrea
[1]
https://hypernews.cern.ch/HyperNews/CMS/get/swReleases/4081.html

[slava77]

Why not just use CommonTools/RecoAlgos/plugins/CaloJetSelector.cc ?

[perrotta]

I'd rather let Silvio provide a more complete answer. As far as he said, using a StringCutObjectSelector is more time consuming than using a fully compiled module.

[slava77]

Is eta selection the only thing needed for filtering? If we split it up in multiple steps, it could be actually faster to just use a more flexible cut parser and select in one go.

Also, if this is needed for HLT, I think you also need a default cfi file

[silviodonato]

@slava77 @fwyzard I proposed this module simply because TSG people told me that the "StringCutObjectSelector" is slow. If you think it is ok, I agree to use the StringCutObjectSelector.

[slava77]

Hi Silvio,

I understand about faster compiled code. What is going to be in the filter chain? Just the Eta range cut or more? If other filters in the path will use cut parser, this particular filter is a bit pointless.

[silviodonato]

Hi Slava,
it is simply a jet selector that I need in order to have a collection of central calo jets for the b-tagging.
Let's us say that I don't use it as filter, but as "central jet collection" maker.

[slava77]

ok, fine.

The remaining point is to have a default cfi file.
Please add one.

[fwyzard]

Or, even better, a fillDescription method.

Ciao,
.Andrea
On 23 Jun 2014 18:52, "Slava Krutelyov" notifications@github.com wrote:

ok, fine.

The remaining point is to have a default cfi file.
Please add one.

Reply to this email directly or view it on GitHub
#4332 (comment).

[silviodonato]

I've put it on:
https://github.com/silviodonato/cmssw/blob/etaSelector/CommonTools/RecoAlgos/python/etaRangeCaloJetSelector_cfi.py

Should I perform a new pull request?
Thanks, Silvio.

(@fwzyzard : about the fillDescription we need to change some of already existing modules, so I've skipped it)

[perrotta]

silviodonato notifications@github.com ha scritto:

I've put it on:
https://github.com/silviodonato/cmssw/blob/etaSelector/CommonTools/RecoAlgos/python/etaRangeCaloJetSelector_cfi.py

Should I perform a new pull request?

No, just update the old one!

---

This message was sent using IMP, the Internet Messaging Program.

[silviodonato]

Ok! Done! https://github.com/silviodonato/cmssw/blob/from-CMSSW_7_1_0_pre9/CommonTools/RecoAlgos/python/etaRangeCaloJetSelector_cfi.py

[cmsbuild]

Pull request #4332 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

[slava77]

+1

for #4332 c756cb1

compiles OK
checked in CMSSW_7_2_X_2014-06-23-1400 (test area sign388)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.