Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalTag.py: remove misleading print out #4336

Merged
merged 1 commit into from Jun 24, 2014

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 21, 2014

Do not print the global tag after expanding it.
This was both misleading (users overriding the global tag would still see the wrong print out) and not in line with the CMSSW practices (messages should be printed via the MessageLogger, not directly to the standard output).

Do not print the global tag after expanding it.
This was both misleading (users overriding the global tag would still see the wrong print out) and not in line with the CMSSW practices (messages should be printed via the MessageLogger, not directly to the standard output).
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_1_X.

GlobalTag.py: remove misleading print out

It involves the following packages:

Configuration/AlCa

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@rcastello
Copy link

+1
I guess it refers to the problem spotted here: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/1519/2/2/1.html
thanks @fwyzard for fixing it.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@ktf ktf modified the milestones: Next CMSSW_7_1_X, CMSSW_7_1_0 Jun 23, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 24, 2014
GlobalTag.py: remove misleading print out
@davidlange6 davidlange6 merged commit 81d6881 into cms-sw:CMSSW_7_1_X Jun 24, 2014
@fwyzard fwyzard deleted the GlobalTag_remove_printout branch December 23, 2014 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants