Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt edmConfigEditor for unscheduled mode #4353

Merged
merged 1 commit into from Jun 26, 2014

Conversation

ahinzmann
Copy link
Contributor

Usually ConfigEditor displays all existing path in a configuration.
In unscheduled mode, instead it now shows all modules requested in the output commands.
This does not modify reconstruction, just improves the visual browsing of configuration files.
This is very useful for the PAT tutorial taking place June 30.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_1_X.

Adapt edmConfigEditor for unscheduled mode

It involves the following packages:

FWCore/GuiBrowsers

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Jun 23, 2014

+1
Nothing that can be tested here.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

is this change already in 72x?

@ahinzmann
Copy link
Contributor Author

No, not yet. Should I make another pull request for that? Or is this going to be forward ported automatically?

@davidlange6
Copy link
Contributor

pls make a pull request (so effectively back porting not forward porting). thx

On Jun 24, 2014, at 11:02 AM, ahinzmann notifications@github.com
wrote:

No, not yet. Should I make another pull request for that? Or is this going to be forward ported automatically?


Reply to this email directly or view it on GitHub.

@ahinzmann
Copy link
Contributor Author

Done:
#4366

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 26, 2014
Adapt edmConfigEditor for unscheduled mode
@davidlange6 davidlange6 merged commit 8669654 into cms-sw:CMSSW_7_1_X Jun 26, 2014
@ktf ktf mentioned this pull request Jun 26, 2014
ktf added a commit to ktf/cmssw that referenced this pull request Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants