Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dictionaries #4361

Merged
merged 1 commit into from Jun 24, 2014
Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 23, 2014

The ROOT team has written (in ROOT6) a routine to check for missing dictionaries for classes used persistently. While testing this routine, I found three missing dictionaries for persistent classes. This has not caused a problem, because all three classes are instances of std::vector, and root can usually handle std::vector without a dictionary if it has a dictionary for T. However, such handling is less efficient without a dictionary. This pull request adds the missing dictionaries.
This pull request is totally technical, so signatures should be bypassed if not signed in a reasonable amount of time.
I tested this pull request with the short relval matrix and saw no errors.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_X.

Add missing dictionaries

It involves the following packages:

DataFormats/EgammaCandidates
DataFormats/ParticleFlowCandidate

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 24, 2014

+1

for #4361 2f066c0
jenkins OK

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 24, 2014
@ktf ktf merged commit 647b236 into cms-sw:CMSSW_7_2_X Jun 24, 2014
@wmtan wmtan deleted the AddMissingDictionaries branch June 24, 2014 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants