Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary (classes*h) must have unique namespace or/and struct name #4381

Merged
merged 1 commit into from Jun 26, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 24, 2014

This pull request creates or corrects unique namespaces based on package name. This fix is needed for ROOT6 as classes*h files becomes a payload embedded into ROOT6 dictionary, which is executed in an interpreter (Cling) during dictionary loading procedure.
This fix is purely technical, so signatures should be bypassed if not signed in a reasonable amount of time.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_X.

Dictionary (classes*h) must have unique namespace or/and struct name

It involves the following packages:

CondFormats/RunInfo
DataFormats/L1TCalorimeter
DataFormats/L1TGlobal

The following packages do not have a category, yet:

DataFormats/L1TCalorimeter
DataFormats/L1TGlobal

@apfeiffer1, @diguida, @cmsbuild, @nclopezo, @rcastello, @ggovi, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@apfeiffer1
Copy link
Contributor

+1

@diguida
Copy link
Contributor

diguida commented Jun 26, 2014

+1

davidlange6 added a commit that referenced this pull request Jun 26, 2014
Dictionary (classes*h) must have unique namespace or/and struct name
@davidlange6 davidlange6 merged commit 31cb021 into cms-sw:CMSSW_7_2_X Jun 26, 2014
@wmtan wmtan deleted the UniqueDictionaryNames branch June 26, 2014 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants