Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made staic debug controls std::atomics #4421

Merged

Conversation

Dr15Jones
Copy link
Contributor

To avoid race conditions when changing the debug conditions, switched
all the variables to be std::atomics following similar code use in
other classes of this package.
These statics were found by the static analyzer.

To avoid race conditions when changing the debug conditions, switched
all the variables to be std::atomics following similar code use in
other classes of this package.
These statics were found by the static analyzer.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Made staic debug controls std::atomics

It involves the following packages:

EventFilter/CSCRawToDigi

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 30, 2014

@barvic
Victor, could you please check that these changes are ok for the LOCAL_UNPACK case?

@barvic
Copy link
Contributor

barvic commented Jun 30, 2014

LOCAL_UNPACK is for out-of-CMSSW framework compilation. If proposed changes pass current general CMSSW tests, please just proceed with PR signing.

@slava77
Copy link
Contributor

slava77 commented Jun 30, 2014

+1

for #4421 5d8cab6
code diff ok
jenkins ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 30, 2014
…RawToDigi

Made staic debug controls std::atomics
@ktf ktf merged commit 6b34487 into cms-sw:CMSSW_7_2_X Jun 30, 2014
@Dr15Jones Dr15Jones deleted the makeDebugAtomicEventFilterCSCRawToDigi branch August 27, 2014 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants