Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 hcx6 #4439

Merged
merged 5 commits into from Jul 3, 2014
Merged

Phase2 hcx6 #4439

merged 5 commits into from Jul 3, 2014

Conversation

bsunanda
Copy link
Contributor

Use vectors

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 hcx6

It involves the following packages:

Geometry/HcalCommonData
Geometry/HcalTestBeamData
SimG4CMS/Calo
SimG4CMS/ShowerLibraryProducer

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jun 30, 2014

@bsunanda - it looks like your previous PR is included in this one. Please, close it if this is the case. Thanks. Yana

@bsunanda
Copy link
Contributor Author

Hi Yana

I started with a base and first made a pull request 4436 and then 4439. So
I believe the request 4439 may include also the changes I put for 4436. I
have not seen this request is signed as yet. Once it is signed I shall
close 4436. Regards

Sunanda

On Mon, 30 Jun 2014, ianna wrote:

@bsunanda - it looks like your previous PR is included in this one. Please,
close it if this is the case. Thanks. Yana


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTcyNz
YwNywiZGF0YSI6eyJpZCI6MzU3OTA3Nzd9fQ==--721bbdfc10f8d94840d8b96d40d31feb2a9
d2548.gif]

@ianna
Copy link
Contributor

ianna commented Jun 30, 2014

+1

@cmsbuild
Copy link
Contributor

-1
Tested at: 51a56dc
When I ran the RelVals I found an error in the following worklfows:
10000 step3

runTheMatrix-results/10000_FourMuPt1_200+FourMuPt_1_200_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_FourMuPt1_200+FourMuPt_1_200_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4439/10/summary.html

@bsunanda
Copy link
Contributor Author

Hi

I am surprised. I ran from the brnach corresponding to 4439
runTheMatrix.py -w upgrade -l 10000

and I get
1 1 1 1 tests passed, 0 0 0 0 failed

There must be something wrong in the test. Please use #4436 and then #4439
over the basic code and this will work. Regards

Sunanda

On Mon, 30 Jun 2014, cmsbuild wrote:

-1
Tested at: 51a56dc
When I ran the RelVals I found an error in the following worklfows:
10000 step3

runTheMatrix-results/10000_FourMuPt1_200+FourMuPt_1_200_2017_GenSimFull+Digi
Full_2017+RecoFull_2017+HARVESTFull_2017/step3_FourMuPt1_200+FourMuPt_1_200_
2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44
39/10/summary.html


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTc0MD
kwNCwiZGF0YSI6eyJpZCI6MzU3OTA3Nzd9fQ==--c22c700c7a7422a520bc7e6969af1b8c588
662ed.gif]

@ianna
Copy link
Contributor

ianna commented Jun 30, 2014

@cmsbuild - I see an error in the full log, but not in the detailed ones - they all pass. Please, double check.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 1, 2014

Hi

Now I have run all the 10 workflows separately and here are my results:
runTheMatrix.py -w upgrade -l 10000
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 10200
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 10400
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 11200
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 11400
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 11600
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 11800
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 12000
1 1 1 1 tests passed, 0 0 0 0 failed
runTheMatrix.py -w upgrade -l 12800
1 1 tests passed, 0 0 failed
runTheMatrix.py -w upgrade -l 13000
1 1 1 1 tests passed, 0 0 0 0 failed

So I do not see any single failure. Workflow 12800 has only 2 steps - I do
not know why. Please suggest what else can be done. Regards

Sunanda

On Mon, 30 Jun 2014, cmsbuild wrote:

-1
Tested at: 51a56dc
When I ran the RelVals I found an error in the following worklfows:
10000 step3

runTheMatrix-results/10000_FourMuPt1_200+FourMuPt_1_200_2017_GenSimFull+Digi
Full_2017+RecoFull_2017+HARVESTFull_2017/step3_FourMuPt1_200+FourMuPt_1_200_
2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44
39/10/summary.html


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTc0MD
kwNCwiZGF0YSI6eyJpZCI6MzU3OTA3Nzd9fQ==--c22c700c7a7422a520bc7e6969af1b8c588
662ed.gif]

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

@mark-grimes
Copy link

merge

tested with muons and pions, only the known issues in HGCal harvesting.

cmsbuild added a commit that referenced this pull request Jul 3, 2014
@cmsbuild cmsbuild merged commit 602d02c into cms-sw:CMSSW_6_2_X_SLHC Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants