Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a unit test for conversion of millepede.res files into DB payloads #44570

Merged
merged 1 commit into from Apr 3, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 28, 2024

PR description:

This PR is a continuation of the series started with #37211 and continued with #43935 and #44434 about unit tests for the MP-II based alignment workflow and adds a new unit test to allow the testing of the conversion of millepede.res files into DB (sqlite payloads). This is performed using the option

process.AlignmentProducer.algoConfig.mode = 'pedeRead'     

of AlignmentProducer and it's a useful to avoid re-running the pede step once a millepede.res is already avaialbles.

PR validation:

Run successfully:

scram b runtests_test_PedeConversion

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44570/39721

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@saumyaphor4252, @consuegs, @perrotta, @cmsbuild can you please review it and eventually sign? Thanks.
@tocheng, @tlampen, @rsreds, @adewit, @mmusich, @yuanchao this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 28, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f030d/38493/summary.html
COMMIT: f6f2e3b
CMSSW: CMSSW_14_1_X_2024-03-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44570/38493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 80 lines to the logs
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3297437
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3297417
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Apr 2, 2024

@cms-sw/alca-l2 do you have comments on this PR?

@perrotta
Copy link
Contributor

perrotta commented Apr 3, 2024

+alca

  • UNit test runs successfully

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7dce3ac into cms-sw:master Apr 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants