Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmsShowFF crash -- root 5.34.18 & new ServiRegistry interface #4458

Merged
merged 6 commits into from Jul 3, 2014

Conversation

alja
Copy link
Contributor

@alja alja commented Jun 30, 2014

In root 5.34.18 gStyle has been auto-destructed due to aggressive clean-up in ~TApplication. This change contains a workaround for this problem.

ServiceRegistry interface has been changed and this PR also contains adaptation to it.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_1_X.

New service registry71

It involves the following packages:

Fireworks/Eve
Fireworks/FWInterface
Fireworks/Geometry

@Dr15Jones, @cmsbuild, @alja, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja alja changed the title New service registry71 fix cmsShowFF crash -- root 5.34.18 & new ServiRegistry interface Jun 30, 2014
@alja
Copy link
Contributor Author

alja commented Jun 30, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@alja
Copy link
Contributor Author

alja commented Jun 30, 2014

Problem was reported by @arizzi

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jul 3, 2014
fix cmsShowFF crash -- root 5.34.18 & new ServiRegistry interface
@davidlange6 davidlange6 merged commit 71ff1a5 into cms-sw:CMSSW_7_1_X Jul 3, 2014
@alja alja deleted the newServiceRegistry71 branch November 8, 2014 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants