Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing EE FEDs for RAW2DIGI process in Shashlik geometry #4470

Merged
merged 1 commit into from Jul 3, 2014

Conversation

shervin86
Copy link
Contributor

Fixing crashes in reconstruction for Shashlik geometry.
I don't understand why it happens only for few events, but running on the entire file:
root://cmsxrootd-site.fnal.gov//store/relval/CMSSW_6_2_0_SLHC14/RelValSingleGammaPt35/GEN-SIM-DIGI-RAW/DES23_62_V1_UPG2023SHNoTaper-v1/00000/94D0E325-20F5-E311-9DF5-0026189438F5.root
there was not crash any more removing the RAW2DIGI process for EE FEDs

@boudoul @davidlange6 @kknb1056

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

A new Pull Request was created by @shervin86 for CMSSW_6_2_X_SLHC.

Removing EE FEDs for RAW2DIGI process in Shashlik geometry

It involves the following packages:

SLHCUpgradeSimulations/Configuration

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

Ping @ianna. Looking at the change I think it probably needs the go ahead from Geometry, but because of the package the bot hasn't recognised that.

All tests pass except for the known failures in HGCal harvesting.

@shervin86, FED numbers 601-609 and 646-654 are still in process.ecalDigis.orderedFedList, does that matter?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

-1
Tested at: d4b8460
When I ran the RelVals I found an error in the following worklfows:
11200 step3

runTheMatrix-results/11200_FourMuPt1_200+FourMuPt_1_200_2019WithGEM_GenSimFull+DigiFull_2019WithGEM+RecoFull_2019WithGEM+HARVESTFull_2019WithGEM/step3_FourMuPt1_200+FourMuPt_1_200_2019WithGEM_GenSimFull+DigiFull_2019WithGEM+RecoFull_2019WithGEM+HARVESTFull_2019WithGEM.log

10200 step3

runTheMatrix-results/10200_FourMuPt1_200+FourMuPt_1_200_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019/step3_FourMuPt1_200+FourMuPt_1_200_2019_GenSimFull+DigiFull_2019+RecoFull_2019+HARVESTFull_2019.log
----- Begin Fatal Exception 01-Jul-2014 23:40:51 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
   Additional Info:
      [a] Another exception was caught while trying to clean up files after the primary fatal exception.
----- End Fatal Exception -------------------------------------------------

10000 step3

runTheMatrix-results/10000_FourMuPt1_200+FourMuPt_1_200_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017/step3_FourMuPt1_200+FourMuPt_1_200_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017.log
----- Begin Fatal Exception 01-Jul-2014 23:40:54 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Calling EventProcessor::runToCompletion (which does almost everything after beginJob and before endJob)
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
   Additional Info:
      [a] Another exception was caught while trying to clean up files after the primary fatal exception.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4470/18/summary.html

@mark-grimes
Copy link

I'm happy to ignore the cmsbuild errors, I tested privately and didn't have any problems plus it's a minor config change. If @ianna is also happy with the change I'll merge ready for the new release.

@mark-grimes
Copy link

merge

cmsbuild added a commit that referenced this pull request Jul 3, 2014
Removing EE FEDs for RAW2DIGI process in Shashlik geometry
@cmsbuild cmsbuild merged commit 146a420 into cms-sw:CMSSW_6_2_X_SLHC Jul 3, 2014
@shervin86 shervin86 deleted the FixRaw2DigiShashlik branch November 22, 2014 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants