Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang compiler errors and warnings in DQMServices/Core #4475

Merged
merged 1 commit into from Jul 3, 2014

Conversation

Dr15Jones
Copy link
Contributor

clang was failing to compile becuase of unused variable errors in
DQMStore. Also fixed warnings about forward declarations not being
the same type as struct/class declarations.

clang was failing to compile becuase of unused variable errors in
DQMStore. Also fixed warnings about forward declarations not being
the same type as struct/class declarations.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Fix clang compiler errors and warnings in DQMServices/Core

It involves the following packages:

DQMServices/Core

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

This fixes the errors found in the CMSSW_7_2_CLANG_X_2014-07-01-0200 IB:
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_2_CLANG_X_2014-07-01-0200/DQMServices/Core

@ktf clang is also warning about unknown options which must be coming from scram:
warning: unknown warning option '-Werror=return-local-addr'; did you mean '-Werror=return-stack-address'? [-Wunknown-warning-option]

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

@deguio
Copy link
Contributor

deguio commented Jul 3, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Jul 3, 2014
Fix clang compiler errors and warnings in DQMServices/Core
@nclopezo nclopezo merged commit c023501 into cms-sw:CMSSW_7_2_X Jul 3, 2014
@ktf
Copy link
Contributor

ktf commented Jul 3, 2014

I also fixed the issue with the flag in cms-sw/cmsdist#829

@Dr15Jones Dr15Jones deleted the clangFixDQMServicesCore branch August 27, 2014 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants