Fix bug in TICLLayerTileProducer.

[wddgit]

PR description:

Fix bug in TICLLayerTileProducer. The LogDebug statement could access the object pointed to by results when results is not filled. This potentially could cause a seg fault. Issue #42470 reports a seg fault in that part of the code. This bug might or might not be the cause of that seg fault. I did not verify the connection, but the bug should be fixed irregardless. We can monitor the IBs after this PR is merged to see if that failure stops occurring.

This also modifies the module to only call consumes and construct the results object corresponding to the chosen option, a minor optimization.

PR validation:

Relies on existing tests.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44843/40092

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @wddgit for master.

It involves the following packages:

• RecoHGCal/TICL (reconstruction, upgrade)

@mandrenguyen, @jfernan2, @srimanob, @subirsarkar, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @youyingli, @lecriste, @hatakeyamak, @rovere, @apsallid, @forthommel, @sameasy, @felicepantaleo, @sobhatta this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d371e/39080/summary.html
COMMIT: b55dad4
CMSSW: CMSSW_14_1_X_2024-04-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44843/39080/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.78 step 2
25088.203 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 88 lines from the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319826
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

type bug-fix, hgcal

[mandrenguyen]

+1

[felicepantaleo]

Thanks a lot, David.
Symbolic +1 from hgcal reco.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1