Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Interface for photos++ 3.55 to 7_2_X #4533

Merged
merged 2 commits into from Jul 9, 2014
Merged

adding Interface for photos++ 3.55 to 7_2_X #4533

merged 2 commits into from Jul 9, 2014

Conversation

inugent
Copy link
Contributor

@inugent inugent commented Jul 4, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2014

A new Pull Request was created by @inugent for CMSSW_7_2_X.

adding Interface for photos++ 3.55 to 7_2_X

It involves the following packages:

GeneratorInterface/ExternalDecays
GeneratorInterface/PhotosInterface

@vciulli, @nclopezo, @thuer, @cmsbuild, @bendavid, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2014

@vciulli
Copy link
Contributor

vciulli commented Jul 8, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@@ -36,13 +36,14 @@ namespace gen {
static double flat();

private:
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not comment code, simply remove it.

davidlange6 added a commit that referenced this pull request Jul 9, 2014
adding Interface for photos++ 3.55 to 7_2_X
@davidlange6 davidlange6 merged commit 422765f into cms-sw:CMSSW_7_2_X Jul 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants