Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix det-pointer in tracker-rechit used in GlobalTrajectoryBuilderBase #4563

Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Jul 8, 2014

set the set-pointer as well,
related to #4179.

For what FastSim is concerned, it may remove the crash, not obvious will make the mixing meaningful

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2014

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X.

add also the geometry pointer

It involves the following packages:

RecoMuon/GlobalTrackingTools

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@VinInn VinInn changed the title add also the geometry pointer Fix set-pointer in tracker-rechit used in GlobalTrajectoryBuilderBase Jul 8, 2014
@VinInn VinInn changed the title Fix set-pointer in tracker-rechit used in GlobalTrajectoryBuilderBase Fix det-pointer in tracker-rechit used in GlobalTrajectoryBuilderBase Jul 9, 2014
@VinInn
Copy link
Contributor Author

VinInn commented Jul 9, 2014

ping. test?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2014

@lveldere
Copy link
Contributor

lveldere commented Jul 9, 2014

Hi all

Would reconstruction mind signing?

Lukas
for FastSim

@StoyanStoynev
Copy link
Contributor

I was thinking on relying on Jenkins (which are fine) only but I after all I prefer now to run on a larger muon sample. If Slava is more confident (he was reviewing #4179) he can sign off now otherwise I'll run more tests.

@slava77
Copy link
Contributor

slava77 commented Jul 9, 2014

+1

for #4563 12f4b06

jenkins is OK

I don't think a longer workflow on muons will show anything.
Maybe trying muon rereco from RECO inputs is something more relevant, but it seems mostly for a sanity check.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@VinInn
Copy link
Contributor Author

VinInn commented Jul 9, 2014

muon rereco from RECO inputs is definitively something more relevant..
It is a workflow not exercised anywhere and we already found two critical bugs in it
thanks to fastsim reco-mixing.
I think that "muon rereco from RECO inputs" is not validated at the moment, it may even still just crash at the first event...

davidlange6 added a commit that referenced this pull request Jul 9, 2014
Fix det-pointer in tracker-rechit used in GlobalTrajectoryBuilderBase
@davidlange6 davidlange6 merged commit d2e81f8 into cms-sw:CMSSW_7_2_X Jul 9, 2014
@VinInn VinInn deleted the FixGlobalTrajectoryBuilderBase branch July 13, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants