Make system timing correct with unscheduled execution #4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed move semantics to allow CPUTimer to be placed in containers.
In order to properly account for unscheduled execution, the summary timing is now done by SystemTimeKeeper. This way the summary can reuse the signals sent by the ActivityRegistry which includes the signals sent when an unscheduled execution is being triggered.
Reuse the timing measurement made for a module when doing the time accounting for the time a module spends running on a particular path. This avoids having two separate timers running.
Removed the timing infrastructure which was previously used to generate the timing summary. This is no longer needed by the new way of getting the timing summary.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Make system timing correct with unscheduled execution It involves the following packages: FWCore/Framework @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
davidlange6
added a commit
that referenced
this pull request
Jul 9, 2014
…scheduled Make system timing correct with unscheduled execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the system timing summary infrastructure to properly handle unscheduled execution. This is actually a full replacement for the old timing infrastructure where the new code makes use of the service signals instead of having timers embedded all over the framework.