Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lumi skipping for Online DQM Input Sources. #4634

Merged
merged 1 commit into from Jul 15, 2014

Conversation

dmitrijus
Copy link
Contributor

In several cases some lumisections won't appear in our storage,
in such case, we should start processing the next available lumisection.

This commit implements a flag nextLumiTimeoutMillis.
If it is set, each missing lumi will start a timer.
After the timer is triggered, and if and only if the next lumi is
available, the source will switch to that lumi.

For example:

  1. nextLumiTimeMillis is set to 45000
  2. we see files ls0001 ls0002 ls0005
  3. source processes ls 1 and 2
  4. 45 seconds pass
  5. source skips 3..4, and starts processing ls0005

This commit also changes how EoR files work: instead of relying on EoR
content, the source uses the highest seen lumi as the number of lumis.
This is compatible with our code in offline and online (where EoR are,
for now, empty).

In several cases some lumisections won't appear in our storage,
in such case, we should start processing the next available lumisection.

This commit implements a flag _nextLumiTimeoutMillis_.
If it is set, each missing lumi will start a timer.
After the timer is triggered, and if and only if the next lumi is
available, the source will switch to that lumi.

For example:

1. nextLumiTimeMillis is set to 45000
2. we see files ls0001 ls0002 ls0005
3. source processes ls 1 and 2
4. 45 seconds pass
5. source skips 3..4, and starts processing ls0005

This commit also changes how EoR files work: instead of relying on EoR
content, the source uses the highest *seen* lumi as the number of lumis.
This is compatible with our code in offline and online (where EoR are,
for now, empty).
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_7_1_X.

Implement lumi skipping for Online DQM Input Sources.

It involves the following packages:

DQMServices/Components
DQMServices/StreamerIO

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jul 14, 2014

+1
this affects the online only. not run at all in the Jenkins tests.
this code has been tested by dmitrijus already.
[needed for MWGR2]

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jul 15, 2014
Implement lumi skipping for Online DQM Input Sources.
@davidlange6 davidlange6 merged commit 344926a into cms-sw:CMSSW_7_1_X Jul 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants