Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic implementation of NjettinessAdder #4664

Conversation

ferencek
Copy link
Contributor

Made NjettinessAdder more generic so it works with any jet type inheriting from reco::Jet

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_2_X.

More generic implementation of NjettinessAdder

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

@cmsbuild Jenkins need to be rerun (new commits).

@cmsbuild
Copy link
Contributor

Pull request #4664 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

+1
Based on jenkins (for a7c2001) and code review.
In addition to the "generic implementation of NjettinessAdder" contains also some minor code optimization. No issues/diffs in the tests.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 18, 2014
…_from-CMSSW_7_2_0_pre1

More generic implementation of NjettinessAdder
@ktf ktf merged commit 30c61a0 into cms-sw:CMSSW_7_2_X Jul 18, 2014
@ferencek ferencek deleted the NjettinessAdderMadeMoreGeneric_from-CMSSW_7_2_0_pre1 branch July 21, 2014 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants