Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt PF algorithm for high pT jet substructure #4668

Merged
merged 6 commits into from Aug 1, 2014

Conversation

ahinzmann
Copy link
Contributor

Change in PFAlgo to fix the jet mass reconstruction of highly boosted W bosons.
The PFAlgo creates merged photons and neutral hadrons from an excess of energy in ECAL and HCAL.
With this fix, these neutrals are split up into ECAL clusters to enable jet mass measurement.
The change is only applied to merged neutrals containing >=2 ECAL clusters with E>50 GeV and has therefore no effect on low energy reconstruction.

This change increases slightly the number of high momentum neutral particles in the event, but has no impact on jet energy fractions or jet energy scale/resolution. Only jet mass scale/resolution is improved.

Presentations at xPOG and JetMET
https://indico.cern.ch/event/320480/contribution/8
https://indico.cern.ch/event/322766/contribution/5

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_2_X.

Adapt PF algorithm for high pT jet substructure

It involves the following packages:

RecoParticleFlow/PFProducer

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@slava77
Copy link
Contributor

slava77 commented Jul 16, 2014

@lgray @dbenedet
Lindsey and Daniele, please check/confirm this is OK from the egamma side.

Thanks

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

@lgray @dbenedet - ping

@dbenedet
Copy link
Contributor

Hello, this is a change in PFAlgo after the GedPhotons and GedElectrons are already built and selected. So we do no expect it to affect primary electrons and photons. It could have only a little effect on the isolation. We will give a closer look to isolation in the next relval validation.

@@ -2656,37 +2663,78 @@ void PFAlgo::processBlock( const reco::PFBlockRef& blockref,
rawhcalEnergy.push_back(totalHcal);
pivotalClusterRef.push_back(maxEcalRef);
iPivotal.push_back(maxiEcal);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part of the code (all push_backs) is essentially repeated below 6 times. Please make the code more "modular" or restructure it (don't repeat it).

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2014

bot, wake up, see the new commits

@ahinzmann
Copy link
Contributor Author

Hi,
I just checked 38.0 myself and found a bug in the changes I added after the comments from Stoyan Stoynev.
I'm now testing 38.0 again and will post the fix.
Cheers,
Andreas

@ahinzmann
Copy link
Contributor Author

Hi,

I fixed the bug I introduced after the comments from Stoyan Stoynev. I can now claim again what I had in my presentation. No change in jet response/resolution. No change in MET resolution and tails.
Attached are the plots from the 38.0 validation.

Cheers,
Andreas

ak4pfjetschs-response200
ak4pfjetchs-response
met_log

@cmsbuild
Copy link
Contributor

Pull request #4668 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@ahinzmann
Copy link
Contributor Author

bot, please take this version.
(reverted the raw energy entry in PF particles, which is not used in reconstruction, but for debugging)

@cmsbuild
Copy link
Contributor

Pull request #4668 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 29, 2014

ok, I will check this one

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2014

+1

for #4668 4f5fcb7
tested in CMSSW_7_2_X_2014-07-25-0200 (test area sign395)
with extended/higher stat tests.

small differences in PF-related quantities, visible mostly in the distributions of constituents and kinds of constituents. The jet and MET response are essentially unchanged.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Aug 1, 2014
Adapt PF algorithm for high pT jet substructure
@davidlange6 davidlange6 merged commit b8575ee into cms-sw:CMSSW_7_2_X Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants