Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Shashlik to CaloTowers #4701

Merged
merged 2 commits into from Jul 20, 2014
Merged

Conversation

kpedro88
Copy link
Contributor

This commit adds the Shashlik ECAL to the CaloTowers algorithm. It treats the subdet ID EcalShashlik as equivalent to EcalEndcap, passes the EcalRecHitsEK input tag to the algorithm, and specifies some preliminary thresholds equal to 1/2 of the current EB thresholds (based on a suggestion from Shashlik experts).

Validation of the changes, using runTheMatrix 13815 (QCD_Pt_600_800_8TeV with Extended2023SHCalNoTaper), plotting average CaloTower EM energy vs. eta:
old:
caloem_old

new:
caloem_new_th

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_6_2_X_SLHC.

add Shashlik to CaloTowers

It involves the following packages:

RecoLocalCalo/CaloTowersCreator
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @StoyanStoynev, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

All tests run fine. Not sure about the results but I guess that's what the relvals are for.

cmsbuild added a commit that referenced this pull request Jul 20, 2014
@cmsbuild cmsbuild merged commit e2e2010 into cms-sw:CMSSW_6_2_X_SLHC Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants