Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the naming convention of CaloMETs #4709

Merged
merged 15 commits into from Aug 5, 2014

Conversation

TaiSakuma
Copy link
Contributor

Continuing from #4114, this PR removes "corMetGlobalMuons" from the RECO sequence and the event contents of RECO and AOD. The new name is "caloMetM", which was already added to RECO and AOD at #4114 and included in CMSSW_7_2_0_pre1. This PR also replaces "corMetGlobalMuons" with "caloMetM" in various files.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @TaiSakuma (Tai Sakuma) for CMSSW_7_2_X.

change the naming convention of CaloMETs

It involves the following packages:

DQM/Physics
DQMOffline/JetMET
Documentation/DataFormats
ElectroWeakAnalysis/WENu
ElectroWeakAnalysis/WMuNu
FWCore/GuiBrowsers
JetMETCorrections/Type1MET
PhysicsTools/PatAlgos
RecoMET/Configuration
RecoMET/METProducers
Validation/RecoMET
Validation/RecoParticleFlow

@Dr15Jones, @StoyanStoynev, @danduggan, @cmsdoxy, @rovere, @monttj, @cmsbuild, @nclopezo, @deguio, @slava77, @vadler, @Degano, @ojeda, @ktf can you please review it and eventually sign? Thanks.
@nhanvtran, @wmtan, @wddgit, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1

Tested at: fe485cd
I ran the usual tests and I found errors in the following unit tests:

---> test testJetMETCorrectionsType1MET had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4709/382/summary.html

@TaiSakuma
Copy link
Contributor Author

This PR seems to need a few more signatures.

Is it ok to merge this PR?

@TaiSakuma
Copy link
Contributor Author

Hello. Is it possible to merge this PR, please, unless anyone has further comments?

@ktf
Copy link
Contributor

ktf commented Aug 5, 2014

+1

@ktf
Copy link
Contributor

ktf commented Aug 5, 2014

Looks like core signature comes from FWCore/GuiBrowser. Maybe it should be moved to have an analysis only signature?

ktf added a commit that referenced this pull request Aug 5, 2014
Change the naming convention of CaloMETs
@ktf ktf merged commit ced8fd6 into cms-sw:CMSSW_7_2_X Aug 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants