Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive HGC Clustering speed/memory improvements #4715

Merged
merged 12 commits into from Jul 21, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jul 21, 2014

Clustering memory footprint reduced by multiple gigabytes, clustering itself now causes little memory blow-up, O(100 MB) or so, down from 3/4 gigabytes from using a dense matrix.
Clustering timing improved by a factor of ~100, i.e. hour/event -> 30s/event spent on clustering.
Clustering performance appears the same looking at a limited number of events. EM clusters are formed correctly, charged pions look fine, simple jet gun multi-particle response is as before.
No changes in energies.

With DQM the event time in TTBar + 140 PU is at ~5 minutes per event.
Is this OK for now?

NB: I had to turn off the gsf electron tracking since there's no notion of preselection for the HGC clusters. This was causing the electron seeding and track fitting to run very slowly.

@vandreev11 @pfs @amagnan @bsunanda

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_6_2_X_SLHC.

Massive HGC Clustering speed/memory improvements

It involves the following packages:

DataFormats/ParticleFlowCandidate
Fireworks/Calo
Fireworks/ParticleFlow
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
SLHCUpgradeSimulations/Configuration

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @alja, @Dr15Jones, @StoyanStoynev, @slava77, @Degano, @ktf can you please review it and eventually sign? Thanks.
@alja, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

All tests fine.

cmsbuild added a commit that referenced this pull request Jul 21, 2014
Massive HGC Clustering speed/memory improvements
@cmsbuild cmsbuild merged commit ccda478 into cms-sw:CMSSW_6_2_X_SLHC Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants