New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new option dumpPSetID to edmProvDump #4726
Conversation
when given a ParameterSetID.
@@ -755,6 +759,11 @@ ProvenanceDumper::work_() { | |||
phc_.erase(std::unique(phc_.begin(), phc_.end()), phc_.end()); | |||
} | |||
|
|||
if(!dumpPSetID_.empty()) { | |||
dumpParameterSetForID_(edm::ParameterSetID(dumpPSetID_)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if the hash doesn't exist?
A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_2_X. Add new option dumpPSetID to edmProvDump It involves the following packages: IOPool/Common @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks. |
Hi Chris, Now it throws and prints an informative message if the argument is not a 32 character hexadecimal string. Otherwise if it cannot find the ID in the registry it just prints 'We are unable to find the corresponding ParameterSet' (without throwing). This is much better than the first version. I can change this again if you want some other behavior. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
Add new option dumpPSetID to edmProvDump
Add option to edmProvDump to print out a ParameterSet when given a ParameterSetID.