Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option dumpPSetID to edmProvDump #4726

Merged
merged 2 commits into from Jul 22, 2014
Merged

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Jul 21, 2014

Add option to edmProvDump to print out a ParameterSet when given a ParameterSetID.

@@ -755,6 +759,11 @@ ProvenanceDumper::work_() {
phc_.erase(std::unique(phc_.begin(), phc_.end()), phc_.end());
}

if(!dumpPSetID_.empty()) {
dumpParameterSetForID_(edm::ParameterSetID(dumpPSetID_));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if the hash doesn't exist?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wddgit (W. David Dagenhart) for CMSSW_7_2_X.

Add new option dumpPSetID to edmProvDump

It involves the following packages:

IOPool/Common

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

Pull request #4726 was updated. @cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please check and sign again.

@wddgit
Copy link
Contributor Author

wddgit commented Jul 21, 2014

Hi Chris, Now it throws and prints an informative message if the argument is not a 32 character hexadecimal string. Otherwise if it cannot find the ID in the registry it just prints 'We are unable to find the corresponding ParameterSet' (without throwing). This is much better than the first version. I can change this again if you want some other behavior.

@Dr15Jones
Copy link
Contributor

+1
The update looks good enough to me.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 22, 2014
Add new option dumpPSetID to edmProvDump
@ktf ktf merged commit d32acdc into cms-sw:CMSSW_7_2_X Jul 22, 2014
@cmsbuild
Copy link
Contributor

@wddgit wddgit deleted the dumpPSetID branch February 4, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants