GlobalTag_condDBv2.py: remove misleading print out #4728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not print the global tag after expanding it. This was both misleading (users overriding the global tag would still see the wrong print out) and not in line with the CMSSW practices (messages should be printed via the MessageLogger, not directly to the standard output).
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_2_X. GlobalTag_condDBv2.py: remove misleading print out It involves the following packages: Configuration/AlCa @cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
ktf
added a commit
that referenced
this pull request
Jul 24, 2014
GlobalTag_condDBv2.py: remove misleading print out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not print the global tag after expanding it.
This was both misleading (users overriding the global tag would still see the wrong print out) and not in line with the CMSSW practices (messages should be printed via the MessageLogger, not directly to the standard output).