Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label collection for HI MTV #4735

Merged
merged 1 commit into from Jul 25, 2014
Merged

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Jul 22, 2014

Fix a recent problem as discussed in #4669 due to a wrong collection name used in MTV with HI scenario.
We think that the problem should have beed introduced by #4239.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_7_2_X.

fix label collection for HI MTV

It involves the following packages:

Validation/RecoHI

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@kkrajczar, @RylanC24, @richard-cms this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@VinInn
Copy link
Contributor

VinInn commented Jul 23, 2014

Why reconstruction?
and why not DQM?
I do not understand the logic behind signatures about Validation...

@slava77
Copy link
Contributor

slava77 commented Jul 23, 2014

for this one (Validation/RecoHI) I agree, should be just in DQM

@ktf
Copy link
Contributor

ktf commented Jul 23, 2014

Shall I change it?

@slava77
Copy link
Contributor

slava77 commented Jul 24, 2014

yes, please

@Martin-Grunewald
Copy link
Contributor

PING PING
Hi, can RECO just sign it for now and you sort out the signature assignment of this package later?
Thanks!

ktf added a commit that referenced this pull request Jul 25, 2014
Fix label collection for HI MTV
@ktf ktf merged commit a14ceec into cms-sw:CMSSW_7_2_X Jul 25, 2014
ktf added a commit to cms-sw/cms-bot that referenced this pull request Jul 25, 2014
ktf added a commit to cms-sw/cms-bot that referenced this pull request Jul 25, 2014
@slava77
Copy link
Contributor

slava77 commented Jul 25, 2014

+1

post-factum
checked that 140.0 runs now

@rovere rovere deleted the fix_HI_MTV_for_Dr branch October 3, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants