Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor thread-safety improvements to HLTrigger/HLTcore #4747

Conversation

Dr15Jones
Copy link
Contributor

-Converted a static to const to avoid complaints from static analyzer.
-Removed use of HLTConfigCounter since wasn't thread safe and wasn't
actually doing anything useful.

-Converted a static to const to avoid complaints from static analyzer.
-Removed use of HLTConfigCounter since wasn't thread safe and wasn't
 actually doing anything useful.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Minor thread-safety improvements to HLTrigger/HLTcore

It involves the following packages:

HLTrigger/HLTcore

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Martin-Grunewald
Copy link
Contributor

I get an github error:

Switched to branch 'from-CMSSW_7_2_X_2014-07-23-0200'
From .
 * [new ref]                    -> merge-attempt
fatal: Couldn't find remote ref refs/pull/4747/head
Unexpected end of command stream

??

@Dr15Jones
Copy link
Contributor Author

@ktf this pull has the github glitch. What is the way you use to get around it?

@nclopezo
Copy link
Contributor

Hi,

When this happens I tell cms-bot to do

git cms-merge-topic Dr15Jones:threadSafetyImprovementsForHLTriggerHLTcore

using the branch name instead of the pr number.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

nclopezo added a commit that referenced this pull request Jul 23, 2014
…TriggerHLTcore

HLTrigger/HLTcore -- Minor thread-safety improvements
@nclopezo nclopezo merged commit 650999f into cms-sw:CMSSW_7_2_X Jul 23, 2014
@cmsbuild
Copy link
Contributor

@Dr15Jones Dr15Jones deleted the threadSafetyImprovementsForHLTriggerHLTcore branch August 27, 2014 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants