Fix rotation for RPC chambers in ring 4 #4752

ianna · 2014-07-23T08:58:47Z

Match rotation to existing chambers

cmsbuild · 2014-07-23T09:02:57Z

A new Pull Request was created by @ianna for CMSSW_7_1_X.

Fix rotation for RPC chambers in ring 4

It involves the following packages:

Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

civanch · 2014-07-23T09:29:04Z

@ianna, should the fix go also into 7_2_X?

ianna · 2014-07-23T09:33:53Z

@civanch - yes, if the tests run by Piet are ok - to be confirmed today/tomorrow. GTs would need to be updated as well.

cmsbuild · 2014-07-23T16:06:36Z

+1
Tested at: e0978e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4752/1837/summary.html

ktf · 2014-07-23T16:21:08Z

@ianna can you please sign off as well?

davidlange6 · 2014-07-23T16:34:24Z

Not yet please

On Jul 23, 2014, at 6:21 PM, "Giulio Eulisse" <notifications@github.com mailto:notifications@github.com> wrote:

@iannahttps://github.com/ianna can you please sign off as well?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4752#issuecomment-49897725.

ianna · 2014-07-23T16:49:31Z

@ktf - I'm waiting for Piet to test this and confirm that it fixes the problem.

cmsbuild · 2014-07-23T20:14:15Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4752/1837/summary.html

ianna · 2014-07-25T11:39:26Z

@pietverwilligen - ping!

pietverwilligen · 2014-07-25T12:06:19Z

I know, trying since the beginning to see what is wrong. From the tester
everything seems fine, when I reconstruct data i do not see a difference.
greets
Piet

On Fri, Jul 25, 2014 at 1:39 PM, ianna notifications@github.com wrote:

@pietverwilligen https://github.com/pietverwilligen - ping!

—
Reply to this email directly or view it on GitHub
#4752 (comment).

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 345 74 70 642

pietverwilligen · 2014-07-25T13:15:00Z

Hi Yana

There is something I do not understand. When checking the geometry in
Geometry/RPCGeometry/test things seem to be fine. The position of the first
strip in phi has changed and the numbering goes in the opposite way. For
this I loaded in the configfile of the tester:

process.load('Configuration.Geometry.GeometryExtended2015_cff')

And i did a manual check that it is reading the right rpcf.xml file and
indeed is is reading Geometry/MuonCommonData/data/v2/rpcf.xml, exactly the
file we modified. So up to here everything is ok.

If I then do the reconstruction loading also the same config file:

process.load('Configuration.Geometry.GeometryExtended2015_cff')

I get the rechits reconstructed at exactly the same place, so this is not
ok. So I wanted to check manually whether the geometry is fine with
cmsShow. For this I created again cmsSimGeom-14.root by copying from
Fireworks/Geometry/python/dumpSimGeometry_cfg.py (*) and I replaced the
loading of the default geometry (IdealGeometryXML that does not seem to
load rpcf.xml) with again

process.load('Configuration.Geometry.GeometryExtended2015_cff')

If i go navigating the table I see that RE+4 is still RTXU instead of
RTXUR. Can you remind me how you created the SimGeometry? Now that I could
not see it in the geometry i dont know whether I can really trust the
reconstruction I did ...

(*) btw I am working in 711 (data taking MWGR1) but I could not check out
Fireworks/Geometry for this release, so i took it from 710. I was not
expecting that the 711 release does not have Fireworks/Geometry.

greets
Piet

On Fri, Jul 25, 2014 at 2:05 PM, Piet Verwilligen piet.verwilligen@cern.ch
wrote:

I know, trying since the beginning to see what is wrong. From the tester
everything seems fine, when I reconstruct data i do not see a difference.
greets
Piet

On Fri, Jul 25, 2014 at 1:39 PM, ianna notifications@github.com wrote:

@pietverwilligen https://github.com/pietverwilligen - ping!

—
Reply to this email directly or view it on GitHub
#4752 (comment).

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 345 74 70 642

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 345 74 70 642

ianna · 2014-07-25T13:19:41Z

@pietverwilligen you need to add transient reco geometry as well, otherwise the one from DB is picked up:

process.load('Configuration.Geometry.GeometryExtended2015_cff')
process.load('Configuration.Geometry.GeometryExtended2015Reco_cff')

pietverwilligen · 2014-07-25T13:30:48Z

Thanks that worked, now I see indeed RTXUR for RE+4.

On Fri, Jul 25, 2014 at 3:19 PM, ianna notifications@github.com wrote:

@pietverwilligen https://github.com/pietverwilligen you need to add
transient reco geometry as well, otherwise the one from DB is picked up:

process.load('Configuration.Geometry.GeometryExtended2015_cff')
process.load('Configuration.Geometry.GeometryExtended2015Reco_cff')

—
Reply to this email directly or view it on GitHub
#4752 (comment).

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 345 74 70 642

pietverwilligen · 2014-07-25T14:21:45Z

Hi Yana

I think that the fix in principle is ok. and I suspect that it is actually
not solving our problem because also Raw2Digi needs to pick up this
geometry. And I am wondering how to test that....

Is it possible to propagate this fix into the DB Geometry and make a label
(and a new Global Tag) such that the Raw2Digi picks up the correct
geometry? I will write an email to our Raw2Digi contact and the AlCa
conveners.
greets
Piet

On Fri, Jul 25, 2014 at 3:30 PM, Piet Verwilligen piet.verwilligen@cern.ch
wrote:

Thanks that worked, now I see indeed RTXUR for RE+4.

On Fri, Jul 25, 2014 at 3:19 PM, ianna notifications@github.com wrote:

@pietverwilligen https://github.com/pietverwilligen you need to add
transient reco geometry as well, otherwise the one from DB is picked up:

process.load('Configuration.Geometry.GeometryExtended2015_cff')
process.load('Configuration.Geometry.GeometryExtended2015Reco_cff')

—
Reply to this email directly or view it on GitHub
#4752 (comment).

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 345 74 70 642

Piet Verwilligen

INFN -- Sezione di Bari
Via E. Orabona 4
I-70125 Bari, Italy
Phone: +39 345 74 70 642

cmsbuild · 2014-08-03T07:57:50Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

alja · 2014-09-16T15:21:18Z

+1
This change is necessary for visualization too.

alja · 2014-09-16T15:43:26Z

@ianna

Is this correction needed also in 72 ?

ianna · 2014-09-16T16:16:10Z

@alja - yes, when this is in 71x

ianna · 2014-09-16T16:16:52Z

@davidlange6 - it looks like this one is forgotten.

davidlange6 · 2014-09-17T06:10:38Z

@ianna - its not forgotten - in 71x - I want to change all of the geometry at the same time - this and the tracker material model

ianna · 2014-09-17T08:57:58Z

@davidlange6 - it is already used in GR_P_V47 for prompt reco. The xml in the release is out of date.

davidlange6 · 2014-09-17T09:06:05Z

Yes, I'm aware. Its the MC that I am worried about.

On Sep 17, 2014, at 10:57 AM, Ianna Osborne notifications@github.com
wrote:

@davidlange6 - it is already used in GR_P_V47 for prompt reco. The xml in the release is out of date.

—
Reply to this email directly or view it on GitHub.

ktf · 2014-10-16T21:44:39Z

shall we close this?

davidlange6 · 2014-10-25T16:06:43Z

+1

Fix rotation for RPC chambers in ring 4

Fix rotation

e0978e0

ianna added comparison-pending labels Jul 23, 2014

ianna added comparison-available labels Jul 23, 2014

cmsbuild added comparison-available labels Aug 3, 2014

ianna mentioned this pull request Sep 16, 2014

Fix Rotation for RPC Chambers in Ring 4 #5319

Merged

cmsbuild mentioned this pull request Sep 17, 2014

Fix Rotation for RPC Chambers in Ring 4 #5368

Merged

cmsbuild added comparison-available fully-signed geometry-approved orp-approved tests-approved and removed comparison-available fully-signed geometry-approved orp-pending tests-approved labels Oct 25, 2014

cmsbuild added a commit that referenced this pull request Oct 25, 2014

Merge pull request #4752 from ianna/rpc-4-rotation-fix

5463a4d

Fix rotation for RPC chambers in ring 4

cmsbuild merged commit 5463a4d into cms-sw:CMSSW_7_1_X Oct 25, 2014

ianna deleted the rpc-4-rotation-fix branch October 26, 2015 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix rotation for RPC chambers in ring 4 #4752

Fix rotation for RPC chambers in ring 4 #4752

ianna commented Jul 23, 2014

cmsbuild commented Jul 23, 2014

civanch commented Jul 23, 2014

ianna commented Jul 23, 2014

cmsbuild commented Jul 23, 2014

ktf commented Jul 23, 2014

davidlange6 commented Jul 23, 2014

ianna commented Jul 23, 2014

cmsbuild commented Jul 23, 2014

ianna commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

ianna commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

cmsbuild commented Aug 3, 2014

alja commented Sep 16, 2014

alja commented Sep 16, 2014

ianna commented Sep 16, 2014

ianna commented Sep 16, 2014

davidlange6 commented Sep 17, 2014

ianna commented Sep 17, 2014

davidlange6 commented Sep 17, 2014

ktf commented Oct 16, 2014

davidlange6 commented Oct 25, 2014

Fix rotation for RPC chambers in ring 4 #4752

Fix rotation for RPC chambers in ring 4 #4752

Conversation

ianna commented Jul 23, 2014

cmsbuild commented Jul 23, 2014

civanch commented Jul 23, 2014

ianna commented Jul 23, 2014

cmsbuild commented Jul 23, 2014

ktf commented Jul 23, 2014

davidlange6 commented Jul 23, 2014

ianna commented Jul 23, 2014

cmsbuild commented Jul 23, 2014

ianna commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

ianna commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

pietverwilligen commented Jul 25, 2014

cmsbuild commented Aug 3, 2014

alja commented Sep 16, 2014

alja commented Sep 16, 2014

ianna commented Sep 16, 2014

ianna commented Sep 16, 2014

davidlange6 commented Sep 17, 2014

ianna commented Sep 17, 2014

davidlange6 commented Sep 17, 2014

ktf commented Oct 16, 2014

davidlange6 commented Oct 25, 2014