New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promoting as a member of DQMStore and remove static #4756
Conversation
A new Pull Request was created by @deguio for CMSSW_7_2_X. promoting as a member of DQMStore and remove static It involves the following packages: DQMServices/Core @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
-1 I'm afraid this isn't thread safe and functions in Services do need to be thread safe. |
@@ -19,6 +19,7 @@ | |||
# include <stdio.h> | |||
# include <stdlib.h> | |||
# include <cxxabi.h> | |||
# include <iosfwd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <atomic>
Ciao Chris,
Yet, as I said, it's better to be explicitly thread safe, rather than implicitely thanks, |
|
Ciao Chris, |
Ciao Marco, I found In call stack ' CastorMonitorModule::analyze() calls function CastorLEDMonitor::processEvent() calls function CastorLEDMonitor::perChanHists() calls function DQMStore::book1D() calls function DQMStore::book1D() calls function DQMStore::book() calls function DQMStore::print_trace() static variable DQMStore::print_trace()::stream' is accessed , 'CastorMonitorModule::analyze()' overrides 'edm::EDAnalyzer::analyze() virtual' In call stack ' DTDigiForNoiseTask::analyze() calls function DTDigiForNoiseTask::bookHistos() calls function DQMStore::book2D() calls function DQMStore::book2D() calls function DQMStore::book() calls function DQMStore::print_trace() static variable DQMStore::print_trace()::stream' is accessed , 'DTDigiForNoiseTask::analyze()' overrides 'edm::EDAnalyzer::analyze() virtual' In call stack ' DTDigiTask::analyze() calls function DTDigiTask::bookHistos() calls function DQMStore::book2D() calls function DQMStore::book2D() calls function DQMStore::book() calls function DQMStore::print_trace() static variable DQMStore::print_trace()::stream' is accessed , 'DTDigiTask::analyze()' overrides 'edm::EDAnalyzer::analyze() virtual' In call stack ' DTEfficiencyTask::analyze() calls function DTEfficiencyTask::fillHistos() calls function DTEfficiencyTask::bookHistos() calls function DQMStore::book1D() calls function DQMStore::book1D() calls function DQMStore::book() calls function DQMStore::print_trace() static variable DQMStore::print_trace()::stream' is accessed , 'DTEfficiencyTask::analyze()' overrides 'edm::EDAnalyzer::analyze() virtual' In call stack ' DTLocalTriggerTask::analyze() calls function DTLocalTriggerTask::runDCCAnalysis() calls function DTLocalTriggerTask::bookHistos() calls function DQMStore::book2D() calls function DQMStore::book2D() calls function DQMStore::book() calls function DQMStore::print_trace() static variable DQMStore::print_trace()::stream' is accessed , 'DTLocalTriggerTask::analyze()' overrides 'edm::EDAnalyzer::analyze() virtual' In call stack ' DTTestPulsesTask::analyze() calls function DTTestPulsesTask::bookHistos() calls function DQMStore::bookProfile() calls function DQMStore::bookProfile() calls function DQMStore::book() calls function DQMStore::print_trace() static variable DQMStore::print_trace()::stream' is accessed , 'DTTestPulsesTask::analyze()' overrides 'edm::EDAnalyzer::analyze() virtual' There are more but I stopped after the 'D's. Now because these are legacy modules, the framework will only execute one at a time so there is no danger of simulateous calls to |
Ciao Chris, Especially in this case, since this piece of code is used for "private" debugging from the DQM Team, never in production. I'll leave the choice to Fede (and you, of course, since you already gave -1 ;( ) Ciao e grazie, |
My -1 doesn't mean anything to our integration system. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
-1 Tested at: a1ba043 ---> test DQMQualityTestsExample had ERRORS you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing). |
-1 Tested at: a1ba043 ---> test DQMQualityTestsExample had ERRORS you can see the results of the tests here: |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
DQMServices -- promoting as a member of DQMStore and remove static
No description provided.