Add missing iterations

[milosdjordjevic]

Request to add the missing track iterations, the new iter7 and also the iter9 and iter10. This is a temporary fix in order not to ignore the tracks. More detailed studies on the performance of track quality cuts per iteration are coming soon.

[cmsbuild]

A new Pull Request was created by @milosdjordjevic for CMSSW_7_2_X.

Add missing iterations

It involves the following packages:

RecoParticleFlow/Configuration
RecoParticleFlow/PFProducer
RecoParticleFlow/PFTracking

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1
Tested at: f4f191c
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4764/442/summary.html

[bachtis]

The changed code has nothing to do with step1 ..... nor the files changed so this is irrelevant

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4764/442/summary.html

[cmsbuild]

+1
Tested at: f4f191c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4764/452/summary.html

[milosdjordjevic]

I have tested the runTheMatrix tool on a clean CMSSW_7_2_X_2014-07-23-1400 (without the proposed changes in my PR) and it fails to run the 101.0 step1 as well, so this could not be related to the PR.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4764/452/summary.html

[ktf]

Indeed 101.0 is a separate problem. Which should be fixed in next IB.

[bachtis]

HI guys , will this be merged ? Cheers M

[ktf]

Whenever @slava77 or @StoyanStoynev look at it and sign off. Problem with IB solved since a while.

[slava77]

testing now

[slava77]

+1

for #4764 f4f191c

tested with extended tests in CMSSW_7_2_X_2014-07-25-0200 (test area sign398)

Changes are generally small. The effects are most noticeable in the flat-pt qcd sample (matrix wflow 38.0):

• addedMuonsAndHadrons count noticeable reduction [are these collections used for anything, btw? they are not monitored in DQM]
• pfChMet noticeable reshuffling, no change in shape, no increase in tails; similar for pfMets
• mu sumPfChargedHadronPt increases generally (looks like a bounce back up from the "iter7" PR temporary fix to avoid iter7 tracks being discarded #4662 ) neutralHadronEt goes down a bit. These are "muons" in jets.
  
  

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).