Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic EBEE seeding parameters #4772

Merged

Conversation

matteosan1
Copy link
Contributor

Make configurable H/E algorithm selection for electron seed preselection.
Also split Et and H/E thresholds for different eta regions.
Default values for seed reconstruction changed accordingly.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_6_2_X_SLHC.

Topic EBEE seeding parameters

It involves the following packages:

RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaIsolationAlgos

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

Tested with ttbar->lepton and single electrons. Get the following crash in single electrons for HGCalMuon4Eta (test 14451). On further inspection it's in the Integration Build so not due to this pull request.

#5  0x00002b012772e492 in DCCEETCCBlock::addTriggerPrimitivesToCollection() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-07-20-0200/lib/slc5_amd64_gcc472/libEventFilterEcalRawToDigi.so
#6  0x00002b0127737341 in DCCTCCBlock::unpack(unsigned long const**, unsigned int*, short) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-07-20-0200/lib/slc5_amd64_gcc472/libEventFilterEcalRawToDigi.so
#7  0x00002b012772cacd in DCCEEEventBlock::unpackTCCBlocks() () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-07-20-0200/lib/slc5_amd64_gcc472/libEventFilterEcalRawToDigi.so
#8  0x00002b012772d1b6 in DCCEEEventBlock::unpack(unsigned long const*, unsigned long, unsigned int) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-07-20-0200/lib/slc5_amd64_gcc472/libEventFilterEcalRawToDigi.so
#9  0x00002b012769f5df in EcalRawToDigi::produce(edm::Event&, edm::EventSetup const&) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-07-20-0200/lib/slc5_amd64_gcc472/pluginEventFilterEcalRawToDigiPlugins.so
#10 0x00002b0105388ee0 in edm::EDProducer::doEvent(edm::EventPrincipal&, edm::EventSetup const&, edm::CurrentProcessingContext const*) () from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-07-20-0200/lib/slc5_amd64_gcc472/libFWCoreFramework.so

@cmsbuild
Copy link
Contributor

Pull request #4772 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

cmsbuild added a commit that referenced this pull request Jul 25, 2014
@cmsbuild cmsbuild merged commit 995399e into cms-sw:CMSSW_6_2_X_SLHC Jul 25, 2014
@matteosan1 matteosan1 deleted the topic_EBEEseedingParameters branch May 28, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants