Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip writing of root file from Validation/TrackerRecHits classes #4783

Merged
merged 1 commit into from Jul 25, 2014

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Jul 24, 2014

Since these are now a DQMEDAnalyzers, output of root file is the responsibility of DQMFileSaver, so we remove the code (no longer called) that used to do this.
This replaces previous PR #4683.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford for CMSSW_7_2_X.

Strip writing of root file from Validation/TrackerRecHits classes

It involves the following packages:

Validation/TrackerRecHits

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@threus, @VinInn this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jul 25, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 25, 2014
Strip writing of root file from Validation/TrackerRecHits classes
@ktf ktf merged commit 22b4c23 into cms-sw:CMSSW_7_2_X Jul 25, 2014
@wmtford wmtford deleted the recHitValidNoOutput branch August 3, 2014 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants