Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2G HLT DQM Request, Take 2 #4793

Merged
merged 14 commits into from Aug 3, 2014

Conversation

rappoccio
Copy link
Contributor

I have created a new branch to remove RECO from the signature list.

The test I have run with "runTheMatrix" have all passed (as they always have when submitting). However many times it seems that these are only passing accidentally due to small numbers of events in the matrix tests. I have tried to make this more robust by switching from bare C++ pointers to edm::Ptrs. The matrix tests have succeeded again, but hopefully not only accidentally this time.

If there are better suggestions for testing more DQM events please let me know!

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_2_X.

B2G HLT DQM Request, Take 2

It involves the following packages:

HLTriggerOffline/B2G
HLTriggerOffline/Common

The following packages do not have a category, yet:

HLTriggerOffline/B2G

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano, @ktf can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jul 31, 2014

+1
since this is a new package it will have to pass the approval at the next ORP. the code is clean and follows all the recommendations we (DQM) give.
20 new histograms are added for a total of 0.00261MB (overhead excluded).
thanks @rappoccio

davidlange6 added a commit that referenced this pull request Aug 3, 2014
@davidlange6 davidlange6 merged commit ffab9ee into cms-sw:CMSSW_7_2_X Aug 3, 2014
@rappoccio rappoccio deleted the rappoccio_B2G_HLT_DQM_72x branch November 24, 2014 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants