Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shm stream consumer 72 x #4805

Merged
merged 2 commits into from Jul 28, 2014

Conversation

smorovic
Copy link
Contributor

Typedef for the old HLT output module name, requested by TSG for ConfDB compatibility

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smorovic (Srecko Morovic) for CMSSW_7_2_X.

Shm stream consumer 72 x

It involves the following packages:

EventFilter/Utilities

@mommsen, @cmsbuild, @Degano, @emeschi, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@mommsen
Copy link
Contributor

mommsen commented Jul 28, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@@ -31,4 +34,5 @@ DEFINE_FWK_MODULE(EvFRecordInserter);
DEFINE_FWK_MODULE(EvFRecordUnpacker);
DEFINE_FWK_MODULE(RawStreamFileWriterForBU);
DEFINE_FWK_MODULE(EvFOutputModule);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the EvFOutputModule module declaration?

@smorovic
Copy link
Contributor Author

We don't want to remove it, as it intended as a "primary" name of the module.

The ShmStreamConsumer (which is how the old shared-memory based output module was named) is added only due to request of TSG for supporting HLT menus generated by ConfDB. This definition is going to be removed when a new ConfDB version that doesn't have this output module name hardcoded becomes ready (reportedly in early 2015). In the meantime we want to allow configurations to be built using the new name, in fact it is already used in setups like daq2val.

@davidlange6
Copy link
Contributor

ok thanks.

davidlange6 added a commit that referenced this pull request Jul 28, 2014
@davidlange6 davidlange6 merged commit cbe758b into cms-sw:CMSSW_7_2_X Jul 28, 2014
davidlange6 added a commit that referenced this pull request Jul 29, 2014
Shm stream consumer typedef (71X backport of #4805)
@smorovic smorovic deleted the ShmStreamConsumer-72X branch October 7, 2014 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants