Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histograms modifications and enhancement #4826

Merged
merged 28 commits into from Aug 11, 2014
Merged

Histograms modifications and enhancement #4826

merged 28 commits into from Aug 11, 2014

Conversation

archiron
Copy link
Contributor

Here are the small modifications in the file ElectronMcSignalValidator.cc porting on histos presentations (missing legends).
new publish script instead of the three existing which are deleted.
README updated for use of scripts

DQMOffline/EGamma
/interface/ElectronDqmAnalyzerBase.h and src/ElectronDqmAnalyzerBase.cc have beed modified to take into account the setEfficiencyTag into BookH1andDivide histos. same changes have been introduced into Validation/RecoEgamma/plugins/ElectronMcFakePostValidator.cc and Validation/RecoEgamma/plugins/ElectronMcSignalPostValidator.cc

Validation/RecoEgamma/test
few modifications have been made into scripts analyze_gedGsfE.tcsh, finalize_gedGsfE.tcsh, store_gedGsfE.tcsh, and a new one was added (publish_gedGesfE.tcsh).
The file ElectronCompare.cc was modified to take into account the releases wich are compared and the stats legend was moved on the right of the pictures (same moficiations are made with DQMOffline/EGamma/scripts/electronCompare.pyà
a modification was made into txt files for web histos presentation (ElectronMcFakeHistos.txt, ElectronMcSignalHistos.txt).

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @archiron (Chiron) for CMSSW_7_2_X.

Histograms modifications and enhancement

It involves the following packages:

DQMOffline/EGamma
Validation/RecoEgamma

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@richard-cms, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

Pull request #4826 was updated. @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2014

Pull request #4826 was updated. @danduggan, @ojeda, @rovere, @deguio can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2014

@deguio
Copy link
Contributor

deguio commented Aug 11, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Aug 11, 2014
Histograms modifications and enhancement
@ktf ktf merged commit e16d1d2 into cms-sw:CMSSW_7_2_X Aug 11, 2014
@archiron archiron deleted the histosEnhancement branch August 20, 2014 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants