Add Shashlik to METAlgorithm for Phase2 #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Phase2 SHCAL, the reco step will have the following warning: %MSG-w SignCaloSpecificAlgo: METProducer:metNoHF 30-Jul-2014 14:46:45 CDT Run: 1 Event: 1665 ECAL tower cell not assigned to an ECAL subdetector!!! %MSG This is a quick fix, which will simply suppress the above warning. However, it won't provide a correct MET significance calculation as we don't have the resolution per Shashlik tower.
|
A new Pull Request was created by @zhenbinwu (Zhenbin Wu) for CMSSW_6_2_X_SLHC. Add Shashlik to METAlgorithm for Phase2 It involves the following packages: RecoMET/METAlgorithms @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
merge No problems in testing. |
cmsbuild
added a commit
that referenced
this pull request
Jul 31, 2014
Add Shashlik to METAlgorithm for Phase2
zhenbinwu
added a commit
to zhenbinwu/cmssw
that referenced
this pull request
Aug 1, 2014
The previous pull request: cms-sw#4838 might cause potential problem in future. As suggested by Tai, we can just turn off MET significance calculation in CaloMETs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Phase2 SHCAL, the reco step will have the following warning:
%MSG-w SignCaloSpecificAlgo: METProducer:metNoHF 30-Jul-2014 14:46:45 CDT Run: 1 Event: 1665
ECAL tower cell not assigned to an ECAL subdetector!!!
%MSG
This is a quick fix, which will simply suppress the above warning.
However, it won't provide a correct MET significance calculation
as we don't have the resolution per Shashlik tower.