Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of soft electron mva, after fixing #4565 merge conflicts #4842

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jul 31, 2014

Change in GsfElectron data format:

  • rename old mva variable with mva_e_pi
  • add mva_Isolated

This PR just picks what's in #4565 and adds a fix to merge conflict in merging PhysicsTools/SelectorUtils/interface/PFElectronSelector.h
a3409cd is applied on top of CMSSW_7_2_X_2014-07-30-0200
and only PFElectronSelector was touched

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_2_X.

addition of soft electron mva, after fixing #4565 merge conflicts

It involves the following packages:

Configuration/Skimming
DQMOffline/EGamma
DataFormats/EgammaCandidates
DataFormats/ParticleFlowCandidate
PhysicsTools/SelectorUtils
RecoBTag/SoftLepton
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/ElectronIdentification
RecoEgamma/Examples
RecoParticleFlow/PFProducer
Validation/RecoEgamma

@ojeda, @StoyanStoynev, @vlimant, @danduggan, @rovere, @monttj, @cmsbuild, @franzoni, @nclopezo, @deguio, @slava77, @vadler, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @lgray, @ferencek, @pvmulder, @richard-cms, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Jul 31, 2014

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2014

davidlange6 added a commit that referenced this pull request Aug 3, 2014
…m-sdevissc-DataFormatChangeIn72X--fixMerge

addition of soft electron mva, after fixing #4565 merge conflicts
@davidlange6 davidlange6 merged commit d94e6dc into cms-sw:CMSSW_7_2_X Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants